Add reproducer for BufferedChannel partial flush position drift - #4854
Draft
yangxianjungree wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Motivation
This draft PR adds a focused reproducer for a
BufferedChannelfailure mode that can leave the logicalBufferedChannel.position()behind the underlyingFileChannel.position()after a partial flush failure.The suspected production impact is stale entry locations and stale
ledgersMapOffsetbeing published byDefaultEntryLoggerafter the same channel is reused.This is intentionally a reproducer-only draft, not the final fix.
Changes
PartialFailingFileChannelfor tests.BufferedChannel.position()can lag behindFileChannel.position()after a partial flushIOException.BufferedLogChannel.appendLedgersMap()can write a staleledgersMapOffsetafter that position drift.Verification
Passed on
release-4.16.7baseline:After rebasing onto current
branch-4.16, running with-amdid not reach tests in this local environment due to a Maven resource copy error inbuildtools:Notes
If maintainers agree with the failure model, the follow-up fix should likely make the main entrylog writer fail closed after non-recoverable write/flush/force failures, and prevent
appendLedgersMap()from publishing a stale header offset.