test: cover SQLitePersister construction, lifecycle, and load variants#807
Open
adawang1210 wants to merge 1 commit into
Open
test: cover SQLitePersister construction, lifecycle, and load variants#807adawang1210 wants to merge 1 commit into
adawang1210 wants to merge 1 commit into
Conversation
Signed-off-by: adawang <adawang12101210@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage analysis showed several public
SQLitePersisterpaths had no tests:from_values,from_config,copy(), the context-manager protocol, pickling (__getstate__/__setstate__, which the parallelism machinery relies on to ship persisters across processes), and theload()branches forapp_id=None(latest across apps) and explicitsequence_id. This adds focused unit tests for each; no behavior changes.Changes made
tests/core/test_persistence.py: 7 new tests covering constructor classmethods, context-manager connection closing,copy()connection independence, pickle round-trip reconnection, and the remainingload()query branches (including a missingsequence_idreturningNone).How to test
Notes
The
app_id=Nonetest asserts shape rather than which app wins:created_athas second resolution in SQLite, so latest-across-apps ordering is non-deterministic for rapid successive writes (asserting a specific winner would be flaky).Checklist
pytest tests/ --ignore=tests/integration_tests: 580 passed, 5 skipped)git commit -s)