Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CALCITE-4264 Take CPU cost into account in VolcanoCost #2181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasrebele
Copy link
Contributor

No description provided.

@Aaaaaaron
Copy link
Member

Hi
The commit message should like this: [CALCITE-4264] Take CPU cost into account in VolcanoCost (your name)

@@ -97,24 +97,25 @@
return io;
}

int compare(VolcanoCost other) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this method should be private?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants