[CALCITE-4424] Complete non-deterministic function (Jiatao Tao) #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaaaaaron
force-pushed
the
CALCITE-4424
branch
3 times, most recently
from
bf9091d to
1782954
Compare
|
|
Aaaaaaron
force-pushed
the
CALCITE-4424
branch
from
323be33 to
06bce00
Compare
zabetak
added
the
discussion-in-jira
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current only SqlSequenceValueOperator override isDeterministic, func like RAND doesn't override isDeterministic, these func seems are not deterministic(the list comes from "isDynamicFunction"):
SqlAbstractTimeFunction
SqlBaseContextVariable
SqlCurrentDateFunction
SqlRandFunction
SqlRandIntegerFunction