[CALCITE-6834] In query that applies COALESCE to nullable SUM, Enumer… #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableProjectToCalcRule throws AssertionError
…ableProjectToCalcRule throws AssertionError
|
julianhyde
reviewed
Feb 19, 2025
| for (RexNode rexInputRef : rexInputRefs) { | ||
| selectList.add(rexInputRef.accept(rexShuttle)); | ||
| } | ||
| builder.project(selectList.build()); |
There was a problem hiding this comment.
I think you can achieve the same effect with one line of code: use RelBuilder.cast to convert the output row type of aggregate to what project expects it to be. If cast adds a CAST call then project will flatten the expression on top of it.
There was a problem hiding this comment.
What you are referring to here should be RelBuilder.convert, which also requires us to build a new RowType based on Mapping, so I have not made any changes here.
julianhyde
reviewed
Feb 19, 2025
julianhyde
reviewed
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ableProjectToCalcRule throws AssertionError