[CALCITE-6835] Invalid unparse for IS TRUE,IS FALSE,IS NOT TRUE and I… #4214
Conversation
…S NOT FALSE in StarRocksDialect
| @@ -128,6 +132,52 @@ public StarRocksSqlDialect(Context context) { | |||
| timeUnitNode.getParserPosition()); | |||
| SqlFloorFunction.unparseDatetimeFunction(writer, newCall, "DATE_TRUNC", false); | |||
| break; | |||
| case IS_TRUE: | |||
There was a problem hiding this comment.
this won't work if the expression has side effects, e.g., the function is RAND().
There was a problem hiding this comment.
Good catch. I overlooked this non-deterministic expression. If this expression is non-deterministic, I will throw an exception. Or do you have any other more general approaches for handling this situation?
There was a problem hiding this comment.
The only solution I can think of is more complicated: you need to add a new project saving the value of the expression, and then do the expansion for that value.
There was a problem hiding this comment.
Ok, I understand your approach. For this PR, I will throw an exception for non-deterministic expressions.
There was a problem hiding this comment.
Perhaps we'll consider your suggestion later.
…S NOT FALSE in StarRocksDialect