-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[CALCITE-6825] Add support for ALL, SOME, ANY in RelToSqlConverter #4224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conflict can be resolved. I have some minor suggestions in the comments. If there are no issues, we can proceed to merge this PR.
core/src/main/java/org/apache/calcite/sql/fun/SqlQuantifyOperator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please squash the commits and resolve the conflicts. |
Explicitly use ALL for the judgment in SqlQuantifyOperator#not
@NobiGo done |
ALL
,SOME
,ANY
on subQuery likeIN
.not
inSqlQuantifyOperator
to NOT SOME/ALL.JIRA: https://issues.apache.org/jira/browse/CALCITE-6825