Skip to content

[CALCITE-6825] Add support for ALL, SOME, ANY in RelToSqlConverter #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

wangdiao
Copy link

@wangdiao wangdiao commented Mar 4, 2025

  • Add support for ALL, SOME, ANY on subQuery like IN.
  • Add overrite not in SqlQuantifyOperator to NOT SOME/ALL.

JIRA: https://issues.apache.org/jira/browse/CALCITE-6825

Copy link

sonarqubecloud bot commented Mar 4, 2025

Copy link
Contributor

@suibianwanwank suibianwanwank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@NobiGo NobiGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflict can be resolved. I have some minor suggestions in the comments. If there are no issues, we can proceed to merge this PR.

Copy link
Contributor

@NobiGo NobiGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NobiGo NobiGo added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Mar 28, 2025
@NobiGo
Copy link
Contributor

NobiGo commented Mar 28, 2025

Please squash the commits and resolve the conflicts.

Explicitly use ALL for the judgment in SqlQuantifyOperator#not
@wangdiao
Copy link
Author

@NobiGo done

@NobiGo NobiGo merged commit f0ce9ea into apache:main Mar 29, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants