Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6788] LoptOptimizeJoinRule should be able to delegate costs to the planner #4231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CALCITE-6788] LoptOptimizeJoinRule should be able to delegate costs to the planner #4231

wants to merge 1 commit into from
+157 −28

Conversation

rubenada
Copy link
Contributor

@rubenada rubenada commented Mar 7, 2025

A backwards-compatible approach for CALCITE-6788

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2025

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

asolimando
asolimando approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@asolimando asolimando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the functional interface approach, pretty neat, I see no harm as the backward compatibility is guaranteed as it clearly emerges from the tests you have added

@rubenada rubenada added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolimando asolimando asolimando approved these changes

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenada @asolimando