[CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects #4234
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
force-pushed
the
dialect_approx_support
branch
from
a65991d to
9ac1a7a
Compare
|
mihaibudiu
reviewed
Mar 9, 2025
| @@ -8099,14 +8099,24 @@ private void checkLiteral2(String expression, String expected) { | |||
| + "FROM \"foodmart\".\"product\""; | |||
| final String expectedStarRocksSql = "SELECT APPROX_COUNT_DISTINCT(`product_id`)\n" | |||
| + "FROM `foodmart`.`product`"; | |||
| final String expectedMssql = "SELECT APPROX_COUNT_DISTINCT([product_id])\n" | |||
| + "FROM [foodmart].[product]"; | |||
| final String expectedPhoenix = "SELECT APPROX_COUNT_DISTINCT(\"product_id\")\n" | |||
There was a problem hiding this comment.
is this exactly the same as ApproxQuota above?
Is there a benefit having two identical strings?
mihaibudiu
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As description in JIRA: https://issues.apache.org/jira/browse/CALCITE-6879