Skip to content

Commit 211b7a0

Browse files
ammachadoclaude
andcommitted
CAMEL-23703: camel-launcher - actually run brew install/uninstall in POSIX validator
The Homebrew validator prefixed the install and uninstall commands with `export HOME=... HOMEBREW_NO_AUTO_UPDATE=1 brew ...`. With the `export` keyword the shell treats `brew`, its subcommand, the formula path and `--force` as variable names to export rather than a command to run, so on a runner where brew is present the install/uninstall steps were silent no-ops and the validator passed without ever exercising an install. Drop `export` so the assignments become command-prefix environment for brew (the same form the style/audit steps already use), letting the validator fail when an install actually breaks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 8d69d65 commit 211b7a0

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

dsl/camel-jbang/camel-launcher/src/jreleaser/bin/camel-validate.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ validate_homebrew() {
162162
mkdir -p "$BREW_HOME"
163163
local brew_output=""
164164
brew_output=$(cd "$MODULE_DIR" && \
165-
export HOME="$BREW_HOME" \
165+
HOME="$BREW_HOME" \
166166
HOMEBREW_NO_AUTO_UPDATE=1 \
167167
brew install "$formula_file" --force 2>&1 || true)
168168

@@ -207,7 +207,7 @@ validate_homebrew() {
207207
if command -v brew >/dev/null 2>&1; then
208208
local brew_uninst_output=""
209209
brew_uninst_output=$(cd "$MODULE_DIR" && \
210-
export HOME="$BREW_HOME" \
210+
HOME="$BREW_HOME" \
211211
HOMEBREW_NO_AUTO_UPDATE=1 \
212212
brew uninstall "$fmla" --force 2>&1 || true)
213213
echo "INFO: homebrew uninstall output:"

0 commit comments

Comments
 (0)