Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21875: add config for authorization headers #17494

Merged
merged 12 commits into from
Mar 30, 2025

Conversation

jonomorris
Copy link
Contributor

Description

Add options allowing the addition of an Authorization header for Basic or Bearer authentication to client and
asynchronous MDN requests.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@jonomorris
Copy link
Contributor Author

jonomorris commented Mar 18, 2025

/component-test camel-as2

Result ✅ The tests passed successfully

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@jonomorris
Copy link
Contributor Author

jonomorris commented Mar 18, 2025

Updated the metadata on a couple of the new options, adding 'secret'. I need to commit the generated changes.

@davsclaus
Copy link
Contributor

modified:   catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/as2.json
modified:   components/camel-as2/camel-as2-component/src/generated/java/org/apache/camel/component/as2/AS2EndpointUriFactory.java
modified:   components/camel-as2/camel-as2-component/src/generated/resources/META-INF/org/apache/camel/component/as2/as2.json

@jonomorris
Copy link
Contributor Author

jonomorris commented Mar 19, 2025

/component-test camel-as2

Result ❌ The tests failed please check the logs

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@jonomorris
Copy link
Contributor Author

jonomorris commented Mar 19, 2025

/component-test camel-as2

Result ❌ The tests failed please check the logs

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@jonomorris
Copy link
Contributor Author

jonomorris commented Mar 20, 2025

/component-test camel-as2

Result ❌ The tests failed please check the logs

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@jonomorris
Copy link
Contributor Author

jonomorris commented Mar 26, 2025

/component-test camel-as2

Result ❌ The tests failed please check the logs

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@jonomorris
Copy link
Contributor Author

The tests pass locally. I see in the logs Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: The following artifacts could not be resolved: org.apache.camel:camel-buildtools:jar:4.11.0-SNAPSHOT (absent): Could not find artifact org.apache.camel:camel-buildtools:jar:4.11.0-SNAPSHOT

@davsclaus
Copy link
Contributor

LGTM - this is good to merge

@jonomorris
Copy link
Contributor Author

Can someone merge this PR? I don't have the option.

@oscerd
Copy link
Contributor

oscerd commented Mar 28, 2025

Let's wait for 4.11.0 to be cut and then we'll merge for 4.12.0

@davsclaus
Copy link
Contributor

davsclaus commented Mar 30, 2025

/component-test camel-as2

Result ✅ The tests passed successfully

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@davsclaus davsclaus merged commit ec70c5f into apache:main Mar 30, 2025
4 checks passed
@davsclaus
Copy link
Contributor

oh sorry its heavy rain today so sitting inside with the laptop. The 4.11.x has been tagged so I merged this, but it may be a bit to quick.

@jonomorris
Copy link
Contributor Author

Thanks for that Claus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants