Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20937 add azure-storage-datalake span decorator #17592

Conversation

anirudh-04
Copy link
Contributor

Description

Added azure-storage-queue Span decorator.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd oscerd changed the title CAMEL-20937 add azure-storage-queue span decorator CAMEL-20937 add azure-storage-datalake span decorator Mar 27, 2025
@anirudh-04 anirudh-04 force-pushed the CAMEL-20937-azure-storage-datalake-span-decorator branch 2 times, most recently from c7167e5 to 24a55c9 Compare March 27, 2025 15:03
Copy link
Member

@bvahdat bvahdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add FQN of this decorator to the following 2 files:

  • components/camel-observation/src/main/resources/META-INF/services/org.apache.camel.tracing.SpanDecorator

  • components/camel-opentelemetry/src/main/resources/META-INF/services/org.apache.camel.tracing.SpanDecorator


@Override
public String getComponentClassName() {
return "org.apache.camel.component.azure.storage.datalake.DataLakeComponent.java";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .java suffix.

@anirudh-04 anirudh-04 force-pushed the CAMEL-20937-azure-storage-datalake-span-decorator branch from 24a55c9 to b61379c Compare March 28, 2025 08:35
@anirudh-04
Copy link
Contributor Author

@bvahdat thanks for the review! I've made the suggested changes and squashed the commits. Please check.

@bvahdat bvahdat merged commit 3574cea into apache:main Mar 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants