Migrate MavenDownloaderImpl to use MIMA (Minimal Maven)#21450
Migrate MavenDownloaderImpl to use MIMA (Minimal Maven)#21450gnodet wants to merge 1 commit intoapache:mainfrom
Conversation
gnodet
force-pushed
the
CAMEL-migrate-maven-downloader-to-mima
branch
from
f98da5f to
890e7f3
Compare
|
great! I trust your PR - I can look on Monday at how did you do it ;) |
- Replace manual Maven Resolver setup with MIMA library - Remove DIRegistry and manual DI configuration (~650 lines) - Reduce MavenDownloaderImpl from 1,240 to 649 lines (48% reduction) - Add MIMA dependencies (context, embedded-maven, standalone-static) - Remove individual maven-resolver-* dependencies - Preserve all existing functionality: - Dual mode operation (embedded Maven plugin + standalone) - Repository configuration (Maven Central, Apache Snapshots, custom repos) - Settings.xml and settings-security.xml processing - Offline mode, fresh mode, repository resolver - Download listeners and custom timeout configuration - Update MavenVersionManager and ValidateMojo to use new constructor - Delete obsolete DIRegistry, DIRegistryTest, and MavenResolverTest
gnodet
force-pushed
the
CAMEL-migrate-maven-downloader-to-mima
branch
from
890e7f3 to
6265db7
Compare
|
Just out of curiosity - did you generate these MD files using AI or did you write these to control AI? |
They were AI generated, but shouldn't have been integrated in the PR, I removed those. |
|
this is good to be based on that mina project - jbang have switched over as well. The hardcoded version should be a placeholder from parent/pom.xml |
|
@gnodet the PR fails with: looks like there's no transitive dependency on plexus-cipher, but be careful with https://repo1.maven.org/maven2/org/codehaus/plexus/plexus-cipher/ - in codehaus-plexus/plexus-cipher@176289f they added hardcoded iteration count to 310000 and the tests take ages to finish. |
4 participants
Migrates
MavenDownloaderImplfrom manual Maven Resolver setup to MIMA (Minimal Maven) 2.4.39, significantly simplifying the codebase while preserving all functionality.