CAMEL-23720: Add emoji icons to camel-jbang TUI tab headers and centralize glyphs

[ammachado]

Description

Adds emoji icons to the camel-jbang-plugin-tui monitor and centralizes all glyph handling:

• Introduce TuiIcons as the single source of truth for emoji and UI symbols. Add icons to every primary tab header, the More submenu, and the Go to popup; replace hardcoded footer navigation hints with TuiIcons constants.
• Consolidate the More submenu into a single TabRegistry.MoreTab record (icon, name, label, tab), replacing the fragile parallel arrays and the MORE_TAB_KEY_INDEX offset table. PopupManager, McpFacade, and ActionsPopup now read from this one list.
• Derive keyboard shortcuts from Windows-style & mnemonic markers embedded in each label, so the underline offset and the trigger key can no longer drift apart. Mnemonic triggers are case-insensitive.
• Icons use plain 2-column emoji without VS16 variation selectors (CAMEL-23818) to avoid width artifacts.

Review feedback addressed:

• Strip VS16 variation selectors from DEV_PROFILE and WARN so all TuiIcons constants are consistently plain 2-column emoji without VS16, matching the class Javadoc contract.
• Migrate TuiHelper.fileEmoji(), fileEmojiByName(), and detectPomEmoji() to use TuiIcons constants instead of raw emoji literals, completing the glyph centralization.

AI-generated PR description on behalf of Adriano Machado, via Claude Code.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run
• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
• You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
• Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[github-actions]

🧪 CI tested the following changed modules:

• dsl/camel-jbang/camel-jbang-plugin-tui

---

🔬 Scalpel shadow comparison — Scalpel: 2 tested, 1 compile-only — current: 2 all tested

Maveniverse Scalpel detected 3 affected modules (current approach: 2).

⚠️ Modules only in Scalpel (1)

• camel-launcher

Skip-tests mode would test 2 modules (1 direct + 1 downstream), skip tests for 1 (generated code, meta-modules)

Modules Scalpel would test (2)

• camel-jbang-plugin-tui
• camel-launcher-container

Modules with tests skipped (1)

• camel-launcher

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (3 modules)

• Camel :: JBang :: Plugin :: TUI
• Camel :: Launcher
• Camel :: Launcher :: Container

---

⚙️ View full build and test results

[davsclaus]

Review: CAMEL-23720 — Add emoji icons to TUI tab headers and centralize glyphs

Well-structured refactoring across 5 commits. TuiIcons as single source of truth, MoreTab record consolidation, and mnemonic-derived shortcuts are all sound. Excellent test coverage (icon width, VS16 absence, shortcut uniqueness, historical sequence oracle, Browse/Configuration regression guard).

Minor suggestions (non-blocking)

1. TuiHelper.fileEmoji() / fileEmojiByName() still return raw emoji literals — FilesBrowser.fileType() now switches on TuiIcons constants, but the methods producing the values it compares against haven't been migrated. Works because the values are identical, but contradicts the "single source of truth" principle this PR establishes. Good follow-up candidate.

2. VS16 in some constants — DEV_PROFILE = "🛠️" and WARN = "⚠️" contain VS16 (U+FE0F), while the class Javadoc and CAMEL-23818 reference say to avoid it. The primaryTabEmojisHaveNoVariationSelector test only checks PRIMARY_TAB_ICONS. These were pre-existing values; consider cleaning them up or documenting as exceptions.

3. Icon alias naming — TuiIcons.OTEL (🔗) is reused for MCP connection doctor checks (not OTel-related), and TAB_STARTUP reuses QUARKUS (🚀) though Startup isn't Quarkus-specific. Naming nitpicks, not bugs.

None of these are blocking. Nice contribution!

---

This review does not replace specialized tools such as CodeRabbit, Sourcery, or SonarCloud.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.