feat: fix type check for FilteredAdapter using is operator#67
Merged
Conversation
|
|
- Changed line 179: adapter.runtimeType == FilteredAdapter to adapter is FilteredAdapter - Changed line 198: adapter.runtimeType == FilteredAdapter to adapter is FilteredAdapter The previous check would never work since FilteredAdapter is abstract and runtime type would be a concrete implementation like DefaultFilteredAdapter. Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix type check for adapter in core_enforcer.dart
Fix type check for FilteredAdapter using Nov 18, 2025
is operator
is operatoris operator
hsluoyz
added a commit
that referenced
this pull request
Nov 18, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
# [1.7.0](v1.6.0...v1.7.0) (2025-11-18) ### Features * fix type check for FilteredAdapter using `is` operator ([#67](#67)) ([22db549](22db549))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type check
adapter.runtimeType == FilteredAdapterfails becauseFilteredAdapteris abstract—runtime types are concrete implementations likeDefaultFilteredAdapter.Changes
loadFilteredPolicy()(L179):adapter.runtimeType == FilteredAdapter→adapter is FilteredAdapterisFiltered()(L198):adapter.runtimeType == FilteredAdapter→adapter is FilteredAdapterOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.