Skip to content

Add Analytics release scripts #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

bbotella
Copy link
Contributor

CASSANALYTICS-22: Release scripts

CASSANALYTICS-22: Release scripts
@bbotella bbotella requested a review from frankgh May 28, 2025 21:36
@bbotella bbotella requested a review from michaelsembwever June 2, 2025 17:13
Copy link
Contributor

@frankgh frankgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, but in general looking good

Comment on lines +165 to +178
#
# Determine deb/rpm repo series
#

idx=`expr index "$release" -`
if [ $idx -eq 0 ]
then
release_short=${release}
else
release_short=${release:0:$((idx-1))}
fi
release_major=$(echo ${release_short} | cut -d '.' -f 1)
release_minor=$(echo ${release_short} | cut -d '.' -f 2)
repo_series="${release_major}${release_minor}x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section is not applicable

shift $(($OPTIND-1))

release=$1
deb_release=${release/-/\~}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't have a deb release

Comment on lines +49 to +50
#asf_git_repo="${asf_git_repo:-https://gitbox.apache.org/repos/asf}"
asf_git_repo="${asf_git_repo:-https://github.com/bbotella}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this should not be changed, and you should be able to run the script with the asf_git_repo set to https://github.com/bbotella as part of your command variables

Suggested change
#asf_git_repo="${asf_git_repo:-https://gitbox.apache.org/repos/asf}"
asf_git_repo="${asf_git_repo:-https://github.com/bbotella}"
asf_git_repo="${asf_git_repo:-https://gitbox.apache.org/repos/asf}"

execute "./gradlew --no-daemon -Pscala=2.13 -Dorg.gradle.java.home=${java_11_home} -PforceSigning -Prelease=true -Pversion=${release} assemble publish --stacktrace"

echo "Artifacts uploaded, find the staging repository on repository.apache.org, \"Close\" it, and indicate its staging number:" 1>&3 2>&4
read -p "staging number Java 11? " staging_number 1>&3 2>&4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should collect values for both builds :

  • scala 2.12, java11, spark 3
  • scala 2.13, java11, spark 3

Both staging numbers should be included in the email text below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants