-
Notifications
You must be signed in to change notification settings - Fork 44
Add Analytics release scripts #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add Analytics release scripts #115
Conversation
CASSANALYTICS-22: Release scripts
Co-authored-by: mck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, but in general looking good
# | ||
# Determine deb/rpm repo series | ||
# | ||
|
||
idx=`expr index "$release" -` | ||
if [ $idx -eq 0 ] | ||
then | ||
release_short=${release} | ||
else | ||
release_short=${release:0:$((idx-1))} | ||
fi | ||
release_major=$(echo ${release_short} | cut -d '.' -f 1) | ||
release_minor=$(echo ${release_short} | cut -d '.' -f 2) | ||
repo_series="${release_major}${release_minor}x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section is not applicable
shift $(($OPTIND-1)) | ||
|
||
release=$1 | ||
deb_release=${release/-/\~} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't have a deb release
#asf_git_repo="${asf_git_repo:-https://gitbox.apache.org/repos/asf}" | ||
asf_git_repo="${asf_git_repo:-https://github.com/bbotella}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this should not be changed, and you should be able to run the script with the asf_git_repo
set to https://github.com/bbotella
as part of your command variables
#asf_git_repo="${asf_git_repo:-https://gitbox.apache.org/repos/asf}" | |
asf_git_repo="${asf_git_repo:-https://github.com/bbotella}" | |
asf_git_repo="${asf_git_repo:-https://gitbox.apache.org/repos/asf}" |
execute "./gradlew --no-daemon -Pscala=2.13 -Dorg.gradle.java.home=${java_11_home} -PforceSigning -Prelease=true -Pversion=${release} assemble publish --stacktrace" | ||
|
||
echo "Artifacts uploaded, find the staging repository on repository.apache.org, \"Close\" it, and indicate its staging number:" 1>&3 2>&4 | ||
read -p "staging number Java 11? " staging_number 1>&3 2>&4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should collect values for both builds :
- scala 2.12, java11, spark 3
- scala 2.13, java11, spark 3
Both staging numbers should be included in the email text below
CASSANALYTICS-22: Release scripts