Upgrade to Maven 3.8.8 for CASSJAVA-102 #117
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the latest Maven version that still supports Java 8 and newer revapi versions. Tested with: $ docker build -t apache/cassandra-java-driver-testing-ubuntu2204 -f docker/testing/ubuntu2204_java_driver_testing.docker . $ docker run -it <image_id> bash $ mvn --version
SiyaoIsHiding
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
I confirm that docker build and
container_id=\$(docker run -td -e TEST_JAVA_VERSION=${TEST_JAVA_VERSION} -e SERVER_VERSION=${SERVER_VERSION} -e TEST_JAVA_MAJOR_VERSION=${testJavaMajorVersion} -v \$(pwd):/home/docker/cassandra-java-driver apache.jfrog.io/cassan-docker/apache/cassandra-java-driver-testing-ubuntu2204 'sleep 2h')
docker exec --user root \$container_id bash -c \"sudo bash /home/docker/cassandra-java-driver/ci/create-user.sh docker \$(id -u) \$(id -g) /home/docker/cassandra-java-driver\"
docker exec --user docker \$container_id './cassandra-java-driver/ci/run-tests.sh'
Works find in my local environment.
| # install newer maven, 3.8.8 is latest that supports Java 8 | ||
| RUN curl -sL https://dlcdn.apache.org/maven/maven-3/3.8.8/binaries/apache-maven-3.8.8-bin.tar.gz -o apache-maven-3.8.8-bin.tar.gz && \ | ||
| tar xzvf apache-maven-3.8.8-bin.tar.gz | ||
| ENV PATH="/home/docker/apache-maven-3.8.8/bin:$PATH" |
There was a problem hiding this comment.
it came up recently that we should be checksumming anything we download.
that wasn't specifically with docker images in mind, but i think we can still do that.
we did it recently here: bf886bb (there's four SHAs there because we arch and os download possibilities)
michaelsembwever
approved these changes
Jun 10, 2025
|
Thanks - will add the checksum |
|
Added checksum validation for Maven - @michaelsembwever could you take a look and deploy images when you're ready? Accompanying PR has been approved as well: apache/cassandra-java-driver#2042 |
SiyaoIsHiding
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest Maven version that still supports Java 8 and newer revapi versions.
Tested with:
$ docker build -t apache/cassandra-java-driver-testing-ubuntu2204 -f docker/testing/ubuntu2204_java_driver_testing.docker .
$ docker run -it <image_id> bash
$ mvn --version