When creating a cluster and validating the jdk, check the cassandra version #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
szymon-miezal
approved these changes
Sep 18, 2025
szymon-miezal
left a comment
szymon-miezal
left a comment
There was a problem hiding this comment.
The patch makes sense to me, it allows to rely on single source of truth.
DSE 6.x can run on both Java 8 and 11, AFAIR it also adversities itself as C* 4.x, which means running on both versions will be possible.
…ersion common.assert_jdk_valid_for_cassandra_version performs the jdk version check based on only cassandra versions patch by Mick Semb Wever; reviewed by Berenguer Blasi, Szymon Miężał for CASSANDRA-20907
michaelsembwever
force-pushed
the
mck/fix-install-dir-non-c-java-check
branch
from
eaafc45 to
747d0de
Compare
|
|
||
| common.assert_jdk_valid_for_cassandra_version(extension.get_cluster_class(options.install_dir).getNodeClass().get_version_from_build(options.install_dir)) | ||
| node_class = extension.get_cluster_class(options.install_dir).getNodeClass() | ||
| common.assert_jdk_valid_for_cassandra_version(node_class.get_version_from_build(options.install_dir, cassandra=True)) |
Member
Author
There was a problem hiding this comment.
adding cassandra=True is the fix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.assert_jdk_valid_for_cassandra_versionperforms the jdk version check based on only cassandra versions