For upgrade tests correctly use cassandra_version over version, and set protocol_version to highest source version supports #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et protocol_version to highest source version supports Assumption is made that the source version on an upgrade path cannot support a higher protocol_version than the destination version.
…f cluster's default config, can be overridden by test
bereng
reviewed
Apr 10, 2025
| @@ -439,7 +440,7 @@ def init_default_config(self): | |||
| phi_values = {'phi_convict_threshold': 5} | |||
|
|
|||
| # enable read time tracking of repaired data between replicas by default | |||
| if self.cluster.version() >= '4': | |||
| if self.cluster.cassandra_version() >= '4': | |||
There was a problem hiding this comment.
Don't you also need to make that change in L98?
There was a problem hiding this comment.
L98 is
if self.cluster.version() < LooseVersion('3.11.13'):
in def install_nodetool_legacy_parsing
i don't think so… what were your thoughts here ?
There was a problem hiding this comment.
I am obviously missing what is the difference of comparing against a version number and a LooseVersion. Aren't you trying to change behavior depending on the 'embedded' underlying C* versions instead of the 'product' version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
1. Fix places where we need to be using
cassandra_version()(instead of justversion()), now that we support other cluster types.2. for upgrade tests default the protocol_version to the max of the source/starting version in the upgrade path -- the assumption here is that from.max_proto_v will always be within the to.min_proto_v to to.max_proto_v range.
3. for upgrade tests default the endpoint_snitch yaml property to SimpleSnitch. this relates to HCD-129
4. after upgrading a node, check and prune any unsupported config options
5. when creating a cluster (
dtest_setup.create_ccm_cluster(..)) use the correct cluster type subclass6. when upgrading, check (and change if necessary) the cluster class type and the node class type (and copy config files into new config locations)