CASSGO-24 Remove global logger #1765
Conversation
joao-r-reis
changed the title
|
Please format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the We need another committer +1 to merge this. |
tengu-alt
force-pushed
the
logger-refactor
branch
4 times, most recently
from
ccd50b0 to
9aa5d34
Compare
Done. |
tengu-alt
force-pushed
the
logger-refactor
branch
2 times, most recently
from
2a6781c to
c8cfbeb
Compare
|
Just a nit pick, the commit title is in past tense now ( |
Good catch, I'll change it. |
tengu-alt
force-pushed
the
logger-refactor
branch
4 times, most recently
from
6f71a2b to
493c135
Compare
tengu-alt
force-pushed
the
logger-refactor
branch
from
493c135 to
3bd1594
Compare
|
@joao-r-reis Should it be merged? |
|
Please update the commit message to include Jackson as a reviewer and then I'll merge it 👍 |
By default, if the logger in the cluster config is not set, the NewSession() method sets a default logger instance which is a deprecated global variable. patch by Oleksandr Luzhniy; reviewed by João Reis, Stanislav Bychkov, Jackson Fleming, for CASSGO-24
tengu-alt
force-pushed
the
logger-refactor
branch
from
3bd1594 to
5f99d18
Compare
Done |
|
|
||
| // Logger for this ClusterConfig. | ||
| // If not specified, defaults to the global gocql.Logger. | ||
| // If not specified, defaults to the gocql.defaultLogger. |
There was a problem hiding this comment.
defaultLogger is private so you'd have to look at the code to know what this does. Instead this should be:
// If not specified, defaults to using the log package.
There was a problem hiding this comment.
Understood, it makes sense. I will lay a hand on that on the next PRs.
6 participants
This PR removes the global instance of the logger. For now, if the logger in the cluster config is not set, the new approach will set a new instance of the default logger for each session.
Issue: #1766