CASSGO-18 Add MutualTls authenticators to defaultApprovedAuthenticators #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolbertam
force-pushed
the
CASSANDRA-19858
branch
from
f209f9c to
4206c91
Compare
lukasz-antoniak
approved these changes
Aug 29, 2024
martin-sucha
reviewed
Sep 3, 2024
Contributor
martin-sucha
left a comment
martin-sucha
left a comment
There was a problem hiding this comment.
Looks good, thanks! Please update the reviewed by in the commit message.
Contributor
Author
|
will do! Apologies for missing this, I'll update my commit shortly. |
Allow MutualTlsWithPasswordFallbackAuthenticator and MutualTlsAuthenticator as possible authenticators. MutualTlsWithPasswordFallbackAuthenticator should behave functionally the same as PasswordAuthenticator. MutualTlsAuthenticator's current implementation doesn't send AUTHENTICATE messages to the client, but felt it was worth including here in case it is ever enhanced to possibly also require credentials. patch by Andy Tolbert; reviewed by Martin Sucha for CASSANDRA-19858
tolbertam
force-pushed
the
CASSANDRA-19858
branch
from
4206c91 to
3f79659
Compare
Contributor
Author
|
commit updated with no other changes than the commit message itself 👍 |
joao-r-reis
changed the title
Contributor
Contributor
|
Closing this as #1801 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow MutualTlsWithPasswordFallbackAuthenticator and MutualTlsAuthenticator as possible authenticators.
MutualTlsWithPasswordFallbackAuthenticator should behave functionally the same as PasswordAuthenticator.
MutualTlsAuthenticator's current implementation doesn't send AUTHENTICATE messages to the client, but felt it was worth including here in case it is ever enhanced to possibly also require credentials.
patch by Andy Tolbert; reviewed by Martin Sucha for CASSANDRA-19858