CASSGO-40: skip metadata only if prepared result included metadata #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshartig
changed the title
jameshartig
changed the title
Contributor
|
I believe this is already handled in #1822 can you double check? I believe this change was required to support the new result metadata id flag in v5 |
Contributor
Author
|
@joao-r-reis It wasn't handled but we could do it in there if we wanted to. I left a comment here. |
joao-r-reis
approved these changes
Jan 29, 2025
Contributor
|
Yeah let's merge this first, don't forget to add me as a reviewer to the commit msg 👍 |
If the prepare result doesn't include metadata we shouldn't skip metadata when executing the query. Fixes CASSGO-40. Patch by James Hartig; reviewed by João Reis for CASSGO-40
jameshartig
force-pushed
the
no-metadata
branch
from
a924266 to
7afc9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the prepare result doesn't include metadata we shouldn't skip metadata when executing the query. Fixes CASSGO-40.
Patch by James Hartig for CASSGO-40