CASSGO-42: don't panic if no applied column is returned #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshartig
force-pushed
the
cas-panic
branch
2 times, most recently
from
0b61e1f to
97336ec
Compare
joao-r-reis
approved these changes
Jan 29, 2025
I also added checks against MapScan failing which could also trigger this bug. Several integration tests were added to validate various edge cases. Patch by James Hartig; reviewed by João Reis for CASSGO-42
jameshartig
force-pushed
the
cas-panic
branch
from
97336ec to
52c5faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added checks against MapScan failing which could also trigger this bug.
Several integration tests were added to validate various edge cases.
Patch by James Hartig for CASSGO-42