-
Notifications
You must be signed in to change notification settings - Fork 642
CASSGO-75: remove proto 1 and 2 support #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASSGO-75: remove proto 1 and 2 support #1890
Conversation
|
C* 2.0 only supports v1 and v2 but I think that's ok. The java driver also removed support for these two versions. This should be done on a major release though so I think I'm going to get this in for 2.0. Can you create a JIRA? If you don't have an account I'll create the ticket |
7ba70bd to
7b78122
Compare
|
@joao-r-reis , all tests are fixed, can you please restart cicd. |
|
|
Both failures due to the problem with java downloading: That has nothing to do with the PR. |
|
I asked if there are any concerns about this proposal in the slack channel, I'm going to wait a couple of days to see if anything pops up before reviewing and merging this. |
7b78122 to
a6bf247
Compare
|
@dkropachev apologies, I merged another MR which caused a conflict in |
81e66c3 to
15d0689
Compare
|
Can you add the entry to the changelog? |
15d0689 to
d4218fd
Compare
You can't find servers that support only proto 1 or 2. And there is no technical benefits to restrict proto to these versions. So, we can easily remove code that is taking care of these versions. Patch by dkropachev; reviewed by joao-r-reis for CASSGO-75
d4218fd to
a03eee1
Compare
Done |
You can't find servers that support only proto 1 or 2.
And there is no technical benefits to restrict proto to these versions.
So, we can easily remove code that is taking care of these versions.
Fixes: #1888