Skip to content

Conversation

@dkropachev
Copy link
Contributor

@dkropachev dkropachev commented May 29, 2025

You can't find servers that support only proto 1 or 2.
And there is no technical benefits to restrict proto to these versions.
So, we can easily remove code that is taking care of these versions.

Fixes: #1888

@joao-r-reis
Copy link
Contributor

C* 2.0 only supports v1 and v2 but I think that's ok. The java driver also removed support for these two versions. This should be done on a major release though so I think I'm going to get this in for 2.0. Can you create a JIRA? If you don't have an account I'll create the ticket

@dkropachev dkropachev force-pushed the dk/remove-proto2-support branch from 7ba70bd to 7b78122 Compare May 29, 2025 14:39
@dkropachev
Copy link
Contributor Author

@joao-r-reis , all tests are fixed, can you please restart cicd.

@dkropachev
Copy link
Contributor Author

C* 2.0 only supports v1 and v2 but I think that's ok. The java driver also removed support for these two versions. This should be done on a major release though so I think I'm going to get this in for 2.0. Can you create a JIRA? If you don't have an account I'll create the ticket

Done: https://issues.apache.org/jira/browse/CASSGO-75

@dkropachev dkropachev changed the title remove proto 1 and 2 support CASSGO-75: remove proto 1 and 2 support May 29, 2025
@dkropachev
Copy link
Contributor Author

Both failures due to the problem with java downloading:

Downloading: java 17.0.12-zulu

In progress...
9.1%curl: (92) HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR (err 2)

That has nothing to do with the PR.
Btw, it signals that sdkman cache is not working.

@joao-r-reis
Copy link
Contributor

I asked if there are any concerns about this proposal in the slack channel, I'm going to wait a couple of days to see if anything pops up before reviewing and merging this.

@jameshartig
Copy link
Contributor

@dkropachev apologies, I merged another MR which caused a conflict in writeHeader. Just make that method use a single append.

@dkropachev dkropachev force-pushed the dk/remove-proto2-support branch 2 times, most recently from 81e66c3 to 15d0689 Compare June 4, 2025 16:47
@joao-r-reis
Copy link
Contributor

Can you add the entry to the changelog?

@dkropachev dkropachev force-pushed the dk/remove-proto2-support branch from 15d0689 to d4218fd Compare June 4, 2025 17:48
You can't find servers that support only proto 1 or 2.
And there is no technical benefits to restrict proto to these versions.
So, we can easily remove code that is taking care of these versions.

Patch by dkropachev; reviewed by joao-r-reis for CASSGO-75
@dkropachev dkropachev force-pushed the dk/remove-proto2-support branch from d4218fd to a03eee1 Compare June 4, 2025 17:49
@dkropachev
Copy link
Contributor Author

Can you add the entry to the changelog?

Done

@joao-r-reis joao-r-reis merged commit 61c0b48 into apache:trunk Jun 4, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove protoVersion2 support

3 participants