CASSGO-6 Accept peers with empty rack #1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshartig
commented
Jun 19, 2025
joao-r-reis
reviewed
Jun 20, 2025
Contributor
joao-r-reis
left a comment
joao-r-reis
left a comment
There was a problem hiding this comment.
Looks good, left a few comments
host_source.go
Outdated
| h.dataCenter = from.dataCenter | ||
| } | ||
| if h.rack == "" { | ||
| if h.missingRack || h.rack == "" { |
Contributor
There was a problem hiding this comment.
Maybe we should remove the h.rack == "" from here? If now we treat "" as a valid rack.
Contributor
Author
There was a problem hiding this comment.
Yeah, I could see that, I was trying to handle filling in the rack if it was empty but since "" is valid I should remove it.
joao-r-reis
approved these changes
Jun 26, 2025
Contributor
|
Looks good, don't forget to update commit message before merging |
This fixes apache#1706. Patch by James Hartig for CASSGO-6; reviewed by João Reis for CASSGO-6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1706.