CASSGO-98 Do not set compression flag in a frame header when native proto v5 is being used #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-r-reis
approved these changes
Nov 19, 2025
…o v5 is being used Previously, during frame construction, the driver was setting the frame compression flag for each frame if a compressor is set in the ClusterConfig. However, for the Native Protocol 5 version the compression flag is deprecated. While Cassandra 4.0 just ignores this flag, some other third-party applications that rely on v5 proto could experience errors as the body of the frame is not actually compressed. Now it adds the compression flag only if the compressor is set and proto version < 5. Patch by Bohdan Siryk; Reviewed by João Reis for CASSGO-98
Contributor
Author
|
Thanks @joao-r-reis. I've updated the commit message and the changelog (totally forgot about this) |
Contributor
|
Left CI running, I'll check on it tomorrow and merge. |
Contributor
Author
|
Cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Bohdan Siryk; Reviewed by João Reis for CASSGO-98