Skip to content

CASSGO-100 Support frames batching into segment #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
worryg0d wants to merge 14 commits into
base: trunk
Choose a base branch
from
Open

CASSGO-100 Support frames batching into segment #1946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
13ce00c
Support frame to segment batching
worryg0d Apr 30, 2026
774ddb6
address review typos fixes
worryg0d May 20, 2026
6b317c7
flush current segment before flushing big frame
worryg0d May 20, 2026
252360c
removed unsusd global err and return err instead of panic
worryg0d May 22, 2026
4add732
resuable read buffers for codec and godoc
worryg0d May 22, 2026
3d25eec
more unit tests for segmentWriter
worryg0d May 25, 2026
6d74ccb
segmentReader unit tests
worryg0d May 27, 2026
f95fd6f
segment codec benchmarks
worryg0d May 28, 2026
2d0d3ff
fixed data race in test helper
worryg0d May 28, 2026
f641b6e
Prevent write hang and stale timer tick
worryg0d Jun 8, 2026
963774c
segmentWriter benchmark
worryg0d Jun 22, 2026
a830a4c
refactor segment codec to take [][]byte payload instead of contiguous…
worryg0d Jun 23, 2026
246c507
segmentWriter: use writev on large frame path
worryg0d Jun 26, 2026
4b0724e
reusable buffers on segmentCodec and segmentWriter
worryg0d Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions cassandra_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3300,7 +3300,7 @@ func TestNegativeStream(t *testing.T) {
return f.finish()
})

frame, err := conn.exec(context.Background(), writer, nil)
frame, err := conn.execInternal(context.Background(), writer, nil)
if err == nil {
t.Fatalf("expected to get an error on stream %d", stream)
} else if frame != nil {
Expand All @@ -3311,7 +3311,9 @@ func TestNegativeStream(t *testing.T) {
func TestManualQueryPaging(t *testing.T) {
const rowsToInsert = 5

session := createSession(t)
session := createSession(t, func(cfg *ClusterConfig) {
cfg.Logger = NewLogger(LogLevelDebug)
})
defer session.Close()

if err := createTable(session, "CREATE TABLE gocql_test.testManualPaging (id int, count int, PRIMARY KEY (id))"); err != nil {
Expand Down Expand Up @@ -4003,18 +4005,18 @@ func TestQueryCompressionNotWorthIt(t *testing.T) {
session := createSession(t)
defer session.Close()

if err := createTable(session, "CREATE TABLE IF NOT EXISTS gocql_test.compression_now_worth_it(id int, text_col text, PRIMARY KEY (id))"); err != nil {
if err := createTable(session, "CREATE TABLE IF NOT EXISTS gocql_test.compression_not_worth_it(id int, text_col text, PRIMARY KEY (id))"); err != nil {
t.Fatal(err)
}

str := "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890!@#$%^&*()_+"
err := session.Query("INSERT INTO gocql_test.large_size_query (id, text_col) VALUES (?, ?)", "1", str).Exec()
err := session.Query("INSERT INTO gocql_test.compression_not_worth_it (id, text_col) VALUES (?, ?)", "1", str).Exec()
if err != nil {
t.Fatal(err)
}

var result string
err = session.Query("SELECT text_col FROM gocql_test.large_size_query").Scan(&result)
err = session.Query("SELECT text_col FROM gocql_test.compression_not_worth_it").Scan(&result)
if err != nil {
t.Fatal(err)
}
Expand Down
Loading