Add .asf.yaml #1378
Closed
Add .asf.yaml #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeetKunDoug
approved these changes
Apr 22, 2025
JeetKunDoug
left a comment
JeetKunDoug
left a comment
There was a problem hiding this comment.
+1 - thanks for adding the .asf.yml and the copyright notice cleanup.
https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features And remove a few dangling copyright headers that were missed in 3923141 patch by Mick Semb Wever; reviewed by Doug Rohrer for CASSANALYTICS-15
michaelsembwever
force-pushed
the
mck/CASSANALYTICS-44/trunk
branch
from
a8ed2d8 to
27e6989
Compare
Member
Author
|
added another commit to fix some urls and |
michaelsembwever
force-pushed
the
mck/CASSANALYTICS-44/trunk
branch
from
18de4c1 to
ab16cc5
Compare
Member
Author
|
and another commit to get the GHA working… |
Member
Author
|
@JeetKunDoug , need to ask you to quickly review the two small additional commits here 🙏 |
JeetKunDoug
requested changes
Apr 24, 2025
JeetKunDoug
left a comment
JeetKunDoug
left a comment
There was a problem hiding this comment.
A few comments (one that doesn't have anything to do with the review itself, more a policy/procedure question for discussion maybe on Slack) but looking good.
michaelsembwever
force-pushed
the
mck/CASSANALYTICS-44/trunk
branch
from
ab16cc5 to
f90322c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features
And remove a few dangling copyright headers that were missed in 3923141
patch by Mick Semb Wever; reviewed by xxx for CASSANALYTICS-15