Fix autocompletion for role names/user names #3766
Conversation
| # disable completion for CREATE USER. | ||
| if ctxt.matched[0][1].upper() == 'CREATE': | ||
| return [Hint('<username>')] | ||
|
|
||
| session = cass.session | ||
| return [maybe_quote(list(row.values())[0].replace("'", "''")) for row in session.execute("LIST USERS")] | ||
| return map(maybe_escape_name, [row['name'] for row in session.execute("LIST USERS")]) |
There was a problem hiding this comment.
What about using the wrapper protect_name?
https://github.com/datastax/python-driver/blob/master/cassandra/metadata.py#L1567
There was a problem hiding this comment.
protect_name internally calls maybe_escape_name. Maybe I'm missing something, but what would be the benefit of using protect_name?
There was a problem hiding this comment.
Basically, just use the "higher abstraction" provided in the driver? It is just a nit, but I am curious to why protect_name even exists.
There was a problem hiding this comment.
to me it feels like it's more of a legacy method name : datastax/python-driver@0959b5d and not really a higher abstraction. But I don't have a lot of context on the history of these method names
|
+1 (nb) |
patch by Francisco Guerrero; reviewed by TBD for CASSANDRA-20175
frankgh
force-pushed
the
CASSANDRA-20175
branch
from
9be4ee3 to
fabedf3
Compare
…sed memory usage from CASSANDRA-14572 (apache#3766)
patch by Francisco Guerrero; reviewed by TBD for CASSANDRA-20175