CASSANDRA-21177- Adding option for randomizing memtable type in Simul…#4620
Open
shruti-p-s wants to merge 1 commit intoapache:cassandra-5.0from
Open
CASSANDRA-21177- Adding option for randomizing memtable type in Simul…#4620shruti-p-s wants to merge 1 commit intoapache:cassandra-5.0from
shruti-p-s wants to merge 1 commit intoapache:cassandra-5.0from
Conversation
shruti-p-s
force-pushed
the
CASSANDRA-21177
branch
from
70626d6 to
4b0a1af
Compare
maedhroz
reviewed
Mar 3, 2026
test/simulator/main/org/apache/cassandra/simulator/ClusterSimulation.java
Show resolved
Hide resolved
maedhroz
approved these changes
Mar 3, 2026
Contributor
maedhroz
left a comment
maedhroz
left a comment
There was a problem hiding this comment.
LGTM...just need to make sure CI is happy
Contributor
Author
|
CI looks good, only upgrade tests are failing and that seems unrelated (seems to be caused by having Accord in trunk but not in 5.0)
|
netudima
reviewed
Mar 4, 2026
| SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"), | ||
| SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"), | ||
| SHUTDOWN_ANNOUNCE_DELAY_IN_MS("cassandra.shutdown_announce_in_ms", "2000"), | ||
| SIMULATOR_ITERATIONS("simulator.iterations", "3"), |
Contributor
There was a problem hiding this comment.
Do we use CassandraRelevantProperties for properties used by test code only?
Contributor
There was a problem hiding this comment.
SIMULATOR_SEED, SIMULATOR_STARTED, TEST_RANDOM_SEED, etc.?
Contributor
There was a problem hiding this comment.
thanks, than no concerns, if it's an already existing style
Contributor
There was a problem hiding this comment.
At the very least, we didn't start the fire :p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ator tests
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira