Skip to content

CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic#4645

Open
Rajneesh180 wants to merge 1 commit intoapache:trunkfrom
Rajneesh180:CASSANDRA-20178-locale-agnostic-test
Open

CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic#4645
Rajneesh180 wants to merge 1 commit intoapache:trunkfrom
Rajneesh180:CASSANDRA-20178-locale-agnostic-test

Conversation

@Rajneesh180
Copy link

The test SetGetCompactionThroughputTest fails on locales that use a comma (,) as a decimal separator (like de_DE). This PR makes the regex pattern locale-agnostic by using [.,] for decimals.

patch by Rajneesh180; reviewed by TBD for CASSANDRA-20178

patch by Rajneesh180; reviewed by TBD for CASSANDRA-20178

Signed-off-by: Rajneesh180 <rajneeshrehsaan48@gmail.com>
@Rajneesh180
Copy link
Author

Hi @smiklosovic,

This is a one-line fix for CASSANDRA-20178 — the SetGetCompactionThroughputTest regex was doing a literal . match for the decimal separator, which fails on locales that use a comma (e.g. de_DE). Changed to [.,] to make it locale-agnostic.

No logic change, just a regex correction. Happy to adjust if there's a preferred pattern for locale handling in the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant