CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic#4645
Open
Rajneesh180 wants to merge 1 commit intoapache:trunkfrom
Open
CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic#4645Rajneesh180 wants to merge 1 commit intoapache:trunkfrom
Rajneesh180 wants to merge 1 commit intoapache:trunkfrom
Conversation
patch by Rajneesh180; reviewed by TBD for CASSANDRA-20178 Signed-off-by: Rajneesh180 <rajneeshrehsaan48@gmail.com>
Author
|
Hi @smiklosovic, This is a one-line fix for CASSANDRA-20178 — the No logic change, just a regex correction. Happy to adjust if there's a preferred pattern for locale handling in the test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
SetGetCompactionThroughputTestfails on locales that use a comma (,) as a decimal separator (likede_DE). This PR makes the regex pattern locale-agnostic by using[.,]for decimals.patch by Rajneesh180; reviewed by TBD for CASSANDRA-20178