CASSANDRA-20910: Harden final alive admission for foreign nodes#4647
Open
arup-chauhan wants to merge 7 commits intoapache:cassandra-4.1from
Open
CASSANDRA-20910: Harden final alive admission for foreign nodes#4647arup-chauhan wants to merge 7 commits intoapache:cassandra-4.1from
arup-chauhan wants to merge 7 commits intoapache:cassandra-4.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up hardening for CASSANDRA-20910 on 4.1.
This PR adds a regression test and a minimal final-admission guard so a foreign-identity endpoint cannot be marked alive in the
realMarkAlivepath.This is a companion, stacked follow-up to #4618
What This PR Changes
testRealMarkAliveRejectsForeignClusterNodeinGossiperTestGossiper.realMarkAlive(...)whenmaybeBelongsInCluster(...)is falseInvariant Enforced
Test Plan
Using JDK 11: