Causeway 3883 #2926
Open
Causeway 3883 #2926
+1,161
−496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue TODO: remove the debugging in the code though
... DomainObjectInvocationHandler ; removes unused 'resolveObjectChangedEnabled flag
... DomainObjectInvocationHandler ; removes unused 'resolveObjectChangedEnabled flag
no need to hold onto MetaModelContext
... working towards only passing in the pojo's, not their adapters
separating those we want to keep from those we shall remove
…oxy object itself
There was a problem hiding this comment.
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
core/codegen-bytebuddy/src/main/java/org/apache/causeway/core/codegen/bytebuddy/services/ProxyFactoryServiceByteBuddy.java:59
- Using InvocationHandler as the cache key assumes that handlers have proper equals/hashCode implementations. Consider using a stable identifier or ensure that all custom InvocationHandler instances override equals/hashCode to avoid potential cache collisions.
private Map<InvocationHandler, Class<?>> proxyClassByInvocationHandler = _Maps.newConcurrentHashMap();
…appinObject interface makes WIC's threadlocal as the fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.