[CELEBORN-1993] CelebornConf introduces celeborn.<module>.io.threads to specify number of threads used in the client thread pool#3245
Closed
SteNicholas wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new configuration option (celeborn..io.threads) to allow users to specify the number of threads for both the server and client thread pools.
- Updated docs/configuration/network.md with the new configuration property.
- Modified ShuffleClientImpl and FlinkShuffleClientImpl to use conf.networkIoThreads(module) instead of a hardcoded default value.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/configuration/network.md | Added new configuration property for IO threads used in server and client thread pools. |
| client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java | Replaced fixed config value with dynamic value from conf.networkIoThreads(module). |
| client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/client/FlinkShuffleClientImpl.java | Updated to use the new configuration method for retrieving IO threads. |
Files not reviewed (1)
- common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala: Language not supported
Comments suppressed due to low confidence (3)
docs/configuration/network.md:40
- [nitpick] Consider clarifying in the description that this configuration option sets the thread count for both server and client thread pools, and explicitly mention the fallback behavior if not provided.
| celeborn.<module>.io.threads | 8 | false | Number of threads used in the server and client thread pool. If setting <module> to `data`, it works for shuffle client push and fetch data. | | |
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:225
- [nitpick] Ensure that the method conf.networkIoThreads(module) properly validates its return value and falls back to 8 if an invalid or missing configuration is encountered.
dataTransportConf = Utils.fromCelebornConf(conf, module, conf.networkIoThreads(module));
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/client/FlinkShuffleClientImpl.java:177
- [nitpick] Similarly, verify that conf.networkIoThreads(module) in the FlinkShuffleClientImpl properly handles edge cases and returns a sensible default, ensuring consistency with the client implementation.
Utils.fromCelebornConf(conf, module, conf.networkIoThreads(module));
Member
Author
RexXiong
reviewed
May 10, 2025
…to specify number of threads used in the client thread pool
2e8b385 to
35b2ab9
Compare
Member
Author
turboFei
reviewed
May 18, 2025
FMX
approved these changes
May 20, 2025
FMX
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CelebornConfintroducesceleborn.<module>.io.threadsto specify number of threads used in the client thread pool.Why are the changes needed?
ShuffleClientImplandFlinkShuffleClientImpluse fixed configuration expression asconf.getInt("celeborn." + module + ".io.threads", 8). Therefore,CelebornConfshould introduceceleborn.<module>.io.threadsto specify number of threads used in the client thread pool.Does this PR introduce any user-facing change?
CelebornConfaddsceleborn.<module>.io.threadsconfig option.How was this patch tested?
No.