[CELEBORN-1994] Introduce disruptor dependency to support asynchronous logging of log4j2#3246
Closed
SteNicholas wants to merge 2 commits into
Closed
[CELEBORN-1994] Introduce disruptor dependency to support asynchronous logging of log4j2#3246SteNicholas wants to merge 2 commits into
SteNicholas wants to merge 2 commits into
Conversation
Member
Author
|
Ping @pan3793. |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- dev/deps/dependencies-server: Language not supported
- master/pom.xml: Language not supported
- pom.xml: Language not supported
- project/CelebornBuild.scala: Language not supported
- worker/pom.xml: Language not supported
…s logging of log4j2
Contributor
|
According to the log4j docs(https://logging.apache.org/log4j/2.x/manual/async.html), is there a statistically significant difference between asynchronous and synchronous logging solutions? |
Member
|
log4j2 async logger is generally faster than the default, but don't forget to update LICENSE/NOTICE when pulling new deps |
…s logging of log4j2
Member
Author
pan3793
approved these changes
May 12, 2025
Member
Author
FMX
approved these changes
May 13, 2025
FMX
left a comment
FMX
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce disruptor dependency to support asynchronous logging of log4j2.
Why are the changes needed?
We add
-Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelectorinCELEBORN_MASTER_JAVA_OPTSandCELEBORN_WOKRER_JAVA_OPTSfor production environment.AsyncLoggerContextSelectordepends on disruptor dependency. Therefore, it's recommend to introduce disruptor dependency to support log4j2 asynchronous loggers.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Cluster test.