[CELEBORN-1917][FOLLOWUP] Do not wait if total inflight or inflight to a specific worker is lower than threshold

[turboFei]

What changes were proposed in this pull request?

If maxInFlightBytesSizeEnabled, break the limitMaxInFlight waiting if total inflight or inflight to a specific worker is lower than threshold.

Why are the changes needed?

Followup for comment #3248 (comment) incase we miss it.

My earlier query was, should this be || ?
As in, either total inflight is high, or inflight to a specific worker is high (assuming per worker threshold is lower than total !)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Code review.

[turboFei]

cc @DDDominik @mridulm @FMX @RexXiong

[DDDominik]

Using || could lead to global byte limit violations or single worker overload.
The logic here is not about 'when to limit the flow', but about 'when to stop waiting'. It can exit the waiting state only if neither limit is exceeded.

[mridulm]

LGTM

[mridulm]

Actually, @DDDominik is right - I got the logic wrong.
What exists is correct - we dont need this: thanks for the follow up @turboFei - we can close this; apologies for the bother !

[turboFei]

Actually, @DDDominik is right - I got the logic wrong.

What exists is correct - we dont need this: thanks for the follow up @turboFei - we can close this; apologies for the bother !

ok, closed