[CELEBORN-2258][FOLLOWUP] Use IoHandlerFactories for EventLoopGroups to replace deprecated transport-specific event loop groups#3669
Closed
SteNicholas wants to merge 1 commit into
Closed
Conversation
Member
Author
There was a problem hiding this comment.
Pull request overview
Updates Celeborn’s Netty event loop creation utility to follow Netty 4.2’s recommended approach, replacing deprecated transport-specific *EventLoopGroup implementations with IoHandlerFactory + MultiThreadIoEventLoopGroup.
Changes:
- Replace
NioEventLoopGroup/EpollEventLoopGroup/KQueueEventLoopGroupinstantiation withMultiThreadIoEventLoopGroupand transport-specific*IoHandler.newFactory(). - Preserve the existing “conflict avoid chooser” path for NIO by using the
MultiThreadIoEventLoopGroupconstructor that accepts anEventExecutorChooserFactory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…to replace deprecated transport-specific event loop groups
SteNicholas
force-pushed
the
CELEBORN-2258
branch
from
8bd73a7 to
bb509ae
Compare
cxzl25
approved these changes
Apr 22, 2026
Member
Author
|
Merged to main(v0.7.0). |
akpatnam25
pushed a commit
to akpatnam25/incubator-celeborn
that referenced
this pull request
May 15, 2026
…to replace deprecated transport-specific event loop groups ### What changes were proposed in this pull request? Use IoHandlerFactories for EventLoopGroups to replace deprecated transport-specific event loop groups. Backport: apache/spark#52719. ### Why are the changes needed? Netty 4.2 introduces some new APIs, and deprecates some old APIs. As part of your migration to Netty 4.2, we encourage you to look through your code base for opportunities to clean up any use of deprecated APIs. - **IoHandlerFactories for EventLoopGroups** All transport-specific event loop groups, such as `NioEventLoopGroup`, have been deprecated. Integrators should now instead pass a transport-specific `IoHandlerFactory` to a `MultiThreadedEventLoopGroup` constructor. Therefore, Netty 4.2 upgrade could follow the best practices from https://netty.io/wiki/netty-4.2-migration-guide.html#new-best-practices. ### Does this PR resolve a correctness bug? No. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes apache#3669 from SteNicholas/CELEBORN-2258. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use IoHandlerFactories for EventLoopGroups to replace deprecated transport-specific event loop groups.
Backport: apache/spark#52719.
Why are the changes needed?
Netty 4.2 introduces some new APIs, and deprecates some old APIs. As part of your migration to Netty 4.2, we encourage you to look through your code base for opportunities to clean up any use of deprecated APIs.
All transport-specific event loop groups, such as
NioEventLoopGroup, have been deprecated. Integrators should now instead pass a transport-specificIoHandlerFactoryto aMultiThreadedEventLoopGroupconstructor.Therefore, Netty 4.2 upgrade could follow the best practices from https://netty.io/wiki/netty-4.2-migration-guide.html#new-best-practices.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.