[CELEBORN-2318] Miss increment to WRITE_DATA_HARD_SPLIT_COUNT on returning HARD_SPLIT in handlePushData#3676
Closed
kaybhutani wants to merge 1 commit into
Closed
Conversation
kaybhutani
changed the title
kaybhutani
changed the title
SteNicholas
changed the title
SteNicholas
approved these changes
May 8, 2026
Member
|
@kaybhutani, thanks for fixing. LGTM. |
RexXiong
approved these changes
May 8, 2026
Member
|
Thanks. Merged to main(v0.7.0). |
akpatnam25
pushed a commit
to akpatnam25/incubator-celeborn
that referenced
this pull request
May 15, 2026
…rning HARD_SPLIT in handlePushData ### What changes were proposed in this pull request? Missing increment to `WRITE_DATA_HARD_SPLIT_COUNT` on returning HARD_SPLIT ### Why are the changes needed? - The post-restart detection branch in `handlePushData` (Case2: shuffleKey in storageManager but not in shuffleMapperAttempts) returns HARD_SPLIT without incrementing `WRITE_DATA_HARD_SPLIT_COUNT` - The sibling Case1 branch (line 398) and all other HARD_SPLIT return paths already increment it - This makes Case2 invisible to monitoring during rolling restarts ### Does this PR resolve a correctness bug? No ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UTs Closes apache#3676 from kaybhutani/kartikay/missing-hard-split-metric. Authored-by: Kartikay Bhutani <kbhutani0001@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Missing increment to
WRITE_DATA_HARD_SPLIT_COUNTon returning HARD_SPLITWhy are the changes needed?
handlePushData(Case2: shuffleKey in storageManager but not in shuffleMapperAttempts) returns HARD_SPLIT without incrementingWRITE_DATA_HARD_SPLIT_COUNTDoes this PR resolve a correctness bug?
No
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs