Skip to content

[CELEBORN-2321] Avoid locking disk writers during memory split checks #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunchao wants to merge 1 commit into from
+15 −5
Closed

[CELEBORN-2321] Avoid locking disk writers during memory split checks #3680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .../src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,23 @@ public synchronized void flush() {
currentTierWriter.flush(false, false);
}

public synchronized boolean needHardSplitForMemoryShuffleStorage() {
if (!(currentTierWriter instanceof MemoryTierWriter)) {
public boolean needHardSplitForMemoryShuffleStorage() {
// Disk-backed writers never need this memory-only split check. Avoid contending with writes and
// evictions on the hot push path for the common case.
TierWriterBase tierWriter = currentTierWriter;
if (!(tierWriter instanceof MemoryTierWriter)) {
return false;
}
return !storageManager.localOrDfsStorageAvailable()
&& (currentTierWriter.fileInfo().getFileLength() > memoryFileStorageMaxFileSize
|| !MemoryManager.instance().memoryFileStorageAvailable());

synchronized (this) {
tierWriter = currentTierWriter;
if (!(tierWriter instanceof MemoryTierWriter)) {
return false;
}
return !storageManager.localOrDfsStorageAvailable()
&& (tierWriter.fileInfo().getFileLength() > memoryFileStorageMaxFileSize
|| !MemoryManager.instance().memoryFileStorageAvailable());
}
}

public synchronized void write(ByteBuf data) throws IOException {
Expand Down
Loading