Skip to content

pg_dump: fix installcheck failure tests in src/bin/pg_dump #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gongxun0928
Copy link
Contributor

  1. the pattern of DYNAMIC TABLE with SCHEDULE is wrong, fix it
  2. pg_dump with multijob mode will create multiple connections in same ArchiveHandle
  3. sql syntax error in dumpAgg.

/usr/bin/mkdir -p '/code/cloudberry/src/bin/pg_dump'/tmp_check cd . && TESTDIR='/code/cloudberry/src/bin/pg_dump' PATH="/home/gpadmin/install/gpdb/bin:/code/cloudberry/src/bin/pg_dump:$PATH" PGPORT='65432' top_builddir='/code/cloudberry/src/bin/pg_dump/../../..' PG_REGRESS='/code/cloudberry/src/bin/pg_dump/../../../src/test/regress/pg_regress' /usr/bin/prove -I ../../../src/test/perl/ -I . t/*.pl t/001_basic.pl ................ ok
t/002_pg_dump.pl .............. ok
t/003_pg_dump_with_server.pl .. ok
t/010_dump_connstr.pl ......... ok
All tests successful.
Files=4, Tests=7171, 56 wallclock secs ( 0.40 usr 0.05 sys + 9.43 cusr 3.94 csys = 13.82 CPU) Result: PASS

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


1. the pattern of DYNAMIC TABLE with SCHEDULE is wrong, fix it
2. pg_dump with multijob mode will create multiple connections in same ArchiveHandle
3. sql syntax error in dumpAgg.

/usr/bin/mkdir -p '/code/cloudberry/src/bin/pg_dump'/tmp_check
cd . && TESTDIR='/code/cloudberry/src/bin/pg_dump' PATH="/home/gpadmin/install/gpdb/bin:/code/cloudberry/src/bin/pg_dump:$PATH" PGPORT='65432' top_builddir='/code/cloudberry/src/bin/pg_dump/../../..' PG_REGRESS='/code/cloudberry/src/bin/pg_dump/../../../src/test/regress/pg_regress' /usr/bin/prove -I ../../../src/test/perl/ -I .  t/*.pl
t/001_basic.pl ................ ok
t/002_pg_dump.pl .............. ok
t/003_pg_dump_with_server.pl .. ok
t/010_dump_connstr.pl ......... ok
All tests successful.
Files=4, Tests=7171, 56 wallclock secs ( 0.40 usr  0.05 sys +  9.43 cusr  3.94 csys = 13.82 CPU)
Result: PASS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant