Use callback instead of calling ExecFilterJunk() #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
approved these changes
Apr 23, 2025
my-ship-it
reviewed
Apr 23, 2025
gfphoenix78
reviewed
May 8, 2025
1. Added ExecFilterJunkFunc function pointer to JunkFilter struct; 2. Replaced ExecFilterJunk() with function pointer calls; 3. Initialized function pointer in ExecInitJunkFilter() and ExecInitJunkFilterConversion(); 4. Updated all ExecFilterJunk() calls to use the function pointer; This change makes JunkFilter's filtering behavior more extensible and customizable while maintaining existing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes JunkFilter's filtering behavior more extensible and customizable while maintaining existing functionality.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions