Skip to content

chore: change the prompt of pax extension in configure help #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gongxun0928
Copy link
Contributor

The --enable-pax configuration option defaults to 'yes'.
so in the default help information, we need to display the '--disable-pax' option

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


The --enable-pax configuration option defaults to 'yes'. so in the
default help information, we need to display the '--disable-pax' option
@tuhaihe
Copy link
Member

tuhaihe commented Apr 24, 2025

IMO, as a contrib extension, that would be better to disable it by default.

However, we already use the --enable-pax option in some files, could you help update them together, including:

Thanks.

Moreover, welcome to update your commit title by following the template.

@tuhaihe
Copy link
Member

tuhaihe commented Apr 25, 2025

Hi, I started a discussion on changing PAX plugin to be disabled by default: https://lists.apache.org/thread/q1n7hztzzydk1owhn73tc1b4chyhzx85

@tuhaihe tuhaihe self-requested a review May 8, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants