Fix incorrect usage of gp_versionstr in pg_upgrade version check #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjhjstz
force-pushed
the
fix_gp_versionstr
branch
from
082eaae to
f6aa3ff
Compare
reshke
approved these changes
Apr 26, 2025
my-ship-it
approved these changes
May 9, 2025
Previously, the Cloudberry-specific version string was incorrectly written into `versionstr` instead of `gp_versionstr`, breaking the fallback comparison logic in `check_exec()`. This caused version checks to fail when the program output matched the expected Apache Cloudberry format.
my-ship-it
force-pushed
the
fix_gp_versionstr
branch
from
f6aa3ff to
c78f583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Cloudberry-specific version string was incorrectly written into
versionstrinstead ofgp_versionstr, breaking the fallback comparison logic incheck_exec(). This caused version checks to fail when the program output matched the expected Apache Cloudberry format.Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions