Skip to content

Replace pylint with ruff #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replace pylint with ruff #1070

wants to merge 1 commit into from

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Apr 27, 2025

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@tuhaihe tuhaihe marked this pull request as draft April 27, 2025 09:00
@tuhaihe
Copy link
Member Author

tuhaihe commented Apr 28, 2025

# Line too long            - pylint: disable=C0301
# Invalid name             - pylint: disable=C0103

Searched and found many Python files including these comments. For a complete cleanup, we also need to replace these with new ruff rules.

Moreover, the gpMgmt/bin/.rcfile also needs to be revised.

As discussed in the community, the `pylint` package is licensed under
GPL, which falls under Category X and is not allowed to be bundled with
Apache software.

To comply with licensing requirements, we are replacing `pylint` with
`ruff`, an alternative Python linter that is licensed under MIT.

This PR removes `pylint` usage and integrates `ruff` for Python code
linting.

See apache#961
@edespino edespino self-requested a review April 28, 2025 23:25
Copy link
Contributor

@edespino edespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs work. I have an implementation of the necessary changes in this commit:

edespino@babc023

@tuhaihe
Copy link
Member Author

tuhaihe commented Apr 29, 2025

This PR needs work. I have an implementation of the necessary changes in this commit:

edespino@babc023

Hi @edespino, would you like to create a new PR based on the commit? I can close my PR since I need more days to address the feedback.

@edespino
Copy link
Contributor

This PR needs work. I have an implementation of the necessary changes in this commit:
edespino@babc023

Hi @edespino, would you like to create a new PR based on the commit? I can close my PR since I need more days to address the feedback.

@tuhaihe I have created a PR for this work: #1079

@tuhaihe tuhaihe closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants