Skip to content

PAX: Fix buffer overflow in pax rmgr desc function #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

gfphoenix78
Copy link
Contributor

@gfphoenix78 gfphoenix78 commented May 6, 2025

The variable filename is only used to store the filename, not for the relative path to datadir.

It also free the memory allocated by the relpathbackend.

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@gfphoenix78 gfphoenix78 requested a review from jiaqizho May 8, 2025 01:56
@gfphoenix78 gfphoenix78 force-pushed the fix-pax-desc branch 2 times, most recently from c36c01d to 2a837c7 Compare May 8, 2025 11:07
@my-ship-it my-ship-it requested a review from weinan003 May 9, 2025 07:52
The variable filename is only used to store the filename, not for
the relative path to datadir.

It also free the memory allocated by the relpathbackend.
@my-ship-it my-ship-it merged commit 964756f into apache:main May 9, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants