Guest OS rules #10098
Guest OS rules #10098
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10098 +/- ##
=============================================
- Coverage 16.57% 3.90% -12.68%
=============================================
Files 5719 414 -5305
Lines 507200 33748 -473452
Branches 61574 6076 -55498
=============================================
- Hits 84093 1317 -82776
+ Misses 413688 32275 -381413
+ Partials 9419 156 -9263
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
BryanMLima
force-pushed
the
guest-os-rules
branch
from
4835d26 to
796ecb1
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13624 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13720 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13731 |
|
@BryanMLima can you look at the conflicts? |
I will take a look this week, apologies for disappearing 😅 . |
# Conflicts: # engine/schema/src/main/java/com/cloud/host/dao/HostDao.java # engine/schema/src/main/java/com/cloud/host/dao/HostDaoImpl.java # server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java # server/src/main/java/com/cloud/resource/ResourceManagerImpl.java # ui/src/views/infra/HostUpdate.vue
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Description
Currently, ACS provides a feature that enables a guest OS preference for a specific host, prioritizing VMs based on its OS. However, this functionality allows VMs with different OSes to be deployed in a host with a Guest OS defined, as expected as it is only a preference configuration; this is not always desired. For example, keeping proprietary OS in the same host could reduce licensing costs.
This PR tackles this scenario, allowing JavaScript rules, using the JS interpreter introduced in #5909, to direct VMs to specific hosts based on their OS. Different from the guest OS preference, these guest OS rules will be strict. This new feature added a new field,
Guest OS as JS rulein the host edit view to allow users the creation of these rules.This PR depends on #9074, for this reason it is on draft until #9074 is merged.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
In a local lab with two hosts (
host-1andhost-2) I created the guest OS rulevmGuestOs.toLowerCase().indexOf("debian") != -1forhost-2, and deployed multiple VMs using templates and ISOs.host-2was filtered during the deployment.host-2and verified that it was not possible.host-1tohost-2and vice versa.How did you try to break this feature and the system with this change?
I tried to deploy VMs in the same lab without the guest OS rules defined and validated that the deployment of VMs were being done as expected.