Add Hypervisor default as cache mode for disk offerings

[hsato03]

Description

Currently, ACS provides none, write-back and write-through options as cache mode when creating disk offerings.

This PR adds the option Hypervisor default as an alternative to cache mode. By using this option, the KVM hypervisor will choose the cache mode to be used by the disk.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

Disk offering creation

Compute offering with compute only disk offering creation

How Has This Been Tested?

1. I created a disk offering and a compute offering with compute only disk offering using the Hypervisor default as cache mode;
2. I deployed a VM for each offering from step 1;
3. I verified through virt-manager that the disk of both VMs was using the Hypervisor default cache mode, as in the screenshot below.

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (864751d) to head (a20b6d5).

Files with missing lines	Patch %	Lines
...g/apache/cloudstack/storage/to/VolumeObjectTO.java	0.00%	4 Missing ⚠️
...datastore/adapter/ProviderAdapterDiskOffering.java	0.00%	4 Missing ⚠️
...src/main/java/com/cloud/offering/DiskOffering.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #10282   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13263    13265    +2     
=========================================
  Files          5666     5666           
  Lines        497960   497965    +5     
  Branches      60241    60242    +1     
=========================================
+ Hits          80459    80470   +11     
+ Misses       408499   408486   -13     
- Partials       9002     9009    +7     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.00% <10.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12225

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[JoaoJandre]

@hsato03 could you solve the conflicts?

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12472