Skip to content

api,ui: multi arch improvements #10289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 58 commits into
base: 4.20
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jan 28, 2025

Description

This PR adds the following changes concerning multi-arch support:

  • Allow downloading and seeing of aarch64 systemVM template for KVM
  • Improvements in deployments of system VMs including VRs to allow trying deployment with different architecture templates. Operator can now have their routing template with same name for different architectures and CloudStack will attempt deployment with all of them based on the below config. Similarly, now CloudStack will attempt to deploy SSVM and CPVM with different architecture templates available.
  • Configuring preferred system VM architecture for a zone using config - system.vm.preferred.architecture
  • UI changes to display, select and filter architecture fields for resources.
  • API and UI changes to allow filtering resources using arch - listCluster, listHosts, listVirtualMachines

Doc PR: apache/cloudstack-documentation#491

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 47.55332% with 418 lines in your changes missing coverage. Please review.

Project coverage is 16.11%. Comparing base (33cdddf) to head (f58253c).
Report is 21 commits behind head on 4.20.

Files with missing lines Patch % Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java 54.21% 114 Missing and 11 partials ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 28.57% 40 Missing ⚠️
.../network/lb/InternalLoadBalancerVMManagerImpl.java 45.16% 32 Missing and 2 partials ⚠️
...va/com/cloud/network/router/NetworkHelperImpl.java 33.33% 32 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 32 Missing ⚠️
.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java 72.97% 11 Missing and 9 partials ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java 42.85% 20 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 12 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 10 Missing ⚠️
...dstack/storage/datastore/db/ImageStoreDaoImpl.java 0.00% 9 Missing ⚠️
... and 27 more
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10289      +/-   ##
============================================
+ Coverage     16.00%   16.11%   +0.10%     
- Complexity    13105    13192      +87     
============================================
  Files          5651     5652       +1     
  Lines        495870   496246     +376     
  Branches      60049    60099      +50     
============================================
+ Hits          79373    79971     +598     
+ Misses       407634   407371     -263     
- Partials       8863     8904      +41     
Flag Coverage Δ
uitests 4.00% <ø> (+<0.01%) ⬆️
unittests 16.96% <47.55%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr changed the title ui: multi arch improvements api,ui: multi arch improvements Jan 29, 2025
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12835)

@shwstppr
Copy link
Contributor Author

@blueorangutan LLtest

@blueorangutan
Copy link

@shwstppr a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@shwstppr
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12842)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53966 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10289-t12842-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 6, 2025

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12963

@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 6, 2025

@blueorangutan test matrix

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12889)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12888)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12890)

@blueorangutan
Copy link

[SF] Trillian test result (tid-12886)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52284 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10289-t12886-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-12887)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 56247 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10289-t12887-kvm-ubuntu22.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_multiple_mgmt_server_ownership Failure 31.77 test_outofbandmanagement.py

Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <[email protected]>
@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13007

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13008

@shwstppr
Copy link
Contributor Author

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12954)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67383 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10289-t12954-vmware-70u3.zip
Smoke tests completed. 134 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 368.19 test_events_resource.py
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Error 698.07 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Error 871.69 test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Error 205.63 test_internal_lb.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 113.09 test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1523.38 test_network.py
test_02_restore_vm_with_disk_offering Error 57.06 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 62.19 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 60.52 test_vm_strict_host_tags.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants