Improve Quota Statement #10506
Improve Quota Statement #10506
Conversation
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12669 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10506 +/- ##
============================================
+ Coverage 16.15% 16.27% +0.11%
- Complexity 13273 13402 +129
============================================
Files 5666 5680 +14
Lines 498081 499213 +1132
Branches 60267 60360 +93
============================================
+ Hits 80475 81246 +771
- Misses 408593 408929 +336
- Partials 9013 9038 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12689 |
…uotaServiceImplTest
|
I've just successfully builded the packages locally with |
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12742 |
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaStatementCmd.java
Outdated
Show resolved
Hide resolved
...atabase/quota/src/main/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
| logger.debug("Creating quota statement from [{}] usage records for parameters [{}].", quotaUsages.size(), | ||
| ReflectionToStringBuilderUtils.reflectOnlySelectedFields(cmd, "accountName", "accountId", "domainId", "startDate", "endDate", "type", "showDetails")); |
There was a problem hiding this comment.
this seems the reuse of the same array of strings. Not for this PR but maybe we should allow String[] as parameter for ReflectionToStringBuilderUtils.reflectOnlySelectedFields. Or allow some kind of predefined default per class to be registered.
| @@ -469,11 +599,11 @@ protected void warnQuotaTariffUpdateDeprecatedFields(QuotaTariffUpdateCmd cmd) { | |||
| String warnMessage = "The parameter 's%s' for API 'quotaTariffUpdate' is no longer needed and it will be removed in future releases."; | |||
There was a problem hiding this comment.
this can be modern format now (not calling the String.format on the warns), can it?
Description
In the current version, the
quotaStatementAPI is returning the internal ID for account and domain, which is not useful for users, since all APIs use/return the UUID. Also, when theusage_typeparameter is informed, the API shows dummy records.To address those problems:
showresourceswas added to display more information to the user about each usage type;quotaStatementDetailsAPI was created to list more details about each usage type;Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
On CloudMonkey the
quotaStatementAPI was called and:usage_typeno dummy records were showed;showresourcesparameter is properly working;The
quotaStatementDetailsAPI was called successfully as well.