Skip to content

New feature: Reconcile commands (CopyCommand, MigrateCommand, MigrateVolumeCommand) #10514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 13 commits into from
May 2, 2025
+3,769 −90

Reconcile: fix resource_type cannot be null

39979a6
Select commit
Loading
Failed to load commit list.
Merged

New feature: Reconcile commands (CopyCommand, MigrateCommand, MigrateVolumeCommand) #10514

Reconcile: fix resource_type cannot be null
39979a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 28, 2025 in 1s

11.11% of diff hit (target 16.29%)

View this Pull Request on Codecov

11.11% of diff hit (target 16.29%)

Annotations

Check warning on line 804 in agent/src/main/java/com/cloud/agent/Agent.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

agent/src/main/java/com/cloud/agent/Agent.java#L804 

Added line #L804 was not covered by tests

Check warning on line 1028 in agent/src/main/java/com/cloud/agent/Agent.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

agent/src/main/java/com/cloud/agent/Agent.java#L1028 

Added line #L1028 was not covered by tests

Check warning on line 1096 in agent/src/main/java/com/cloud/agent/Agent.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

agent/src/main/java/com/cloud/agent/Agent.java#L1096 

Added line #L1096 was not covered by tests

Check warning on line 105 in api/src/main/java/com/cloud/agent/api/Command.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/Command.java#L103-L105 

Added lines #L103 - L105 were not covered by tests

Check warning on line 119 in api/src/main/java/com/cloud/agent/api/Command.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/Command.java#L119 

Added line #L119 was not covered by tests

Check warning on line 121 in api/src/main/java/com/cloud/agent/api/Command.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/Command.java#L121 

Added line #L121 was not covered by tests

Check warning on line 123 in api/src/main/java/com/cloud/agent/api/Command.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/Command.java#L123 

Added line #L123 was not covered by tests

Check warning on line 125 in api/src/main/java/com/cloud/agent/api/Command.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/Command.java#L125 

Added line #L125 was not covered by tests

Check warning on line 127 in api/src/main/java/com/cloud/agent/api/Command.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/Command.java#L127 

Added line #L127 was not covered by tests

Check warning on line 224 in api/src/main/java/com/cloud/agent/api/to/NetworkTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/NetworkTO.java#L224 

Added line #L224 was not covered by tests

Check warning on line 91 in api/src/main/java/com/cloud/agent/api/to/NicTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/NicTO.java#L89-L91 

Added lines #L89 - L91 were not covered by tests

Check warning on line 95 in api/src/main/java/com/cloud/agent/api/to/NicTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/NicTO.java#L93-L95 

Added lines #L93 - L95 were not covered by tests

Check warning on line 196 in api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java#L194-L196 

Added lines #L194 - L196 were not covered by tests

Check warning on line 198 in api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java#L198 

Added line #L198 was not covered by tests

Check warning on line 31 in api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java#L31 

Added line #L31 was not covered by tests

Check warning on line 36 in api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java#L36 

Added line #L36 was not covered by tests

Check warning on line 40 in api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java#L40 

Added line #L40 was not covered by tests

Check warning on line 45 in api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java#L45 

Added line #L45 was not covered by tests

Check warning on line 50 in api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/command/ReconcileCommandService.java#L50 

Added line #L50 was not covered by tests

Check warning on line 108 in core/src/main/java/com/cloud/agent/api/MigrateCommand.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/com/cloud/agent/api/MigrateCommand.java#L108 

Added line #L108 was not covered by tests

Check warning on line 31 in core/src/main/java/com/cloud/agent/api/PingAnswer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/com/cloud/agent/api/PingAnswer.java#L31 

Added line #L31 was not covered by tests

Check warning on line 57 in core/src/main/java/com/cloud/agent/api/PingAnswer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/com/cloud/agent/api/PingAnswer.java#L55-L57 

Added lines #L55 - L57 were not covered by tests

Check warning on line 61 in core/src/main/java/com/cloud/agent/api/PingAnswer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/com/cloud/agent/api/PingAnswer.java#L59-L61 

Added lines #L59 - L61 were not covered by tests

Check warning on line 65 in core/src/main/java/com/cloud/agent/api/PingAnswer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/com/cloud/agent/api/PingAnswer.java#L63-L65 

Added lines #L63 - L65 were not covered by tests

Check warning on line 87 in core/src/main/java/com/cloud/agent/api/PingCommand.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/com/cloud/agent/api/PingCommand.java#L85-L87 

Added lines #L85 - L87 were not covered by tests
View more details on Codecov